nextest_runner/config/overrides/

imp.rs

// Copyright (c) The nextest Contributors
// SPDX-License-Identifier: MIT OR Apache-2.0

use crate::{
    config::{
        core::{
            EvaluatableProfile, FinalConfig, NextestConfig, NextestConfigImpl, PreBuildPlatform,
        },
        elements::{
            FlakyResult, JunitFlakyFailStatus, LeakTimeout, ReportSkipPolicy, RetryPolicy,
            SlowTimeout, TestGroup, TestPriority, ThreadsRequired,
        },
        scripts::{
            CompiledProfileScripts, DeserializedProfileScriptConfig, ScriptId, WrapperScriptConfig,
        },
    },
    errors::{
        ConfigCompileError, ConfigCompileErrorKind, ConfigCompileSection, ConfigParseErrorKind,
    },
    platform::BuildPlatforms,
    reporter::TestOutputDisplay,
    run_mode::NextestRunMode,
};
use guppy::graph::cargo::BuildPlatform;
use nextest_filtering::{
    BinaryQuery, CompiledExpr, Filterset, FiltersetKind, KnownGroups, ParseContext, TestQuery,
};
use owo_colors::{OwoColorize, Style};
use serde::{Deserialize, Deserializer};
use smol_str::SmolStr;
use std::collections::HashMap;
use target_spec::{Platform, TargetSpec};

/// Settings for a test binary.
#[derive(Clone, Debug)]
pub struct ListSettings<'p, Source = ()> {
    list_wrapper: Option<(&'p WrapperScriptConfig, Source)>,
}

impl<'p, Source: Copy> ListSettings<'p, Source> {
    pub(in crate::config) fn new(
        profile: &'p EvaluatableProfile<'_>,
        query: &BinaryQuery<'_>,
    ) -> Self
    where
        Source: TrackSource<'p>,
    {
        let ecx = profile.filterset_ecx();

        let mut list_wrapper = None;

        for override_ in &profile.compiled_data.scripts {
            if let Some(wrapper) = &override_.list_wrapper
                && list_wrapper.is_none()
            {
                let (wrapper, source) =
                    map_wrapper_script(profile, Source::track_script(wrapper.clone(), override_));

                if !override_
                    .is_enabled_binary(query, &ecx)
                    .expect("test() in list-time scripts should have been rejected")
                {
                    continue;
                }

                list_wrapper = Some((wrapper, source));
            }
        }

        Self { list_wrapper }
    }
}

impl<'p> ListSettings<'p> {
    /// Returns a default list-settings without a wrapper script.
    ///
    /// Debug command used for testing.
    pub fn debug_empty() -> Self {
        Self { list_wrapper: None }
    }

    /// Sets the wrapper to use for list-time scripts.
    ///
    /// Debug command used for testing.
    pub fn debug_set_list_wrapper(&mut self, wrapper: &'p WrapperScriptConfig) -> &mut Self {
        self.list_wrapper = Some((wrapper, ()));
        self
    }

    /// Returns the list-time wrapper script.
    pub fn list_wrapper(&self) -> Option<&'p WrapperScriptConfig> {
        self.list_wrapper.as_ref().map(|(wrapper, _)| *wrapper)
    }
}

/// Settings for individual tests.
///
/// Returned by [`EvaluatableProfile::settings_for`].
///
/// The `Source` parameter tracks an optional source; this isn't used by any public APIs at the
/// moment.
#[derive(Clone, Debug)]
pub struct TestSettings<'p, Source = ()> {
    priority: (TestPriority, Source),
    threads_required: (ThreadsRequired, Source),
    run_wrapper: Option<(&'p WrapperScriptConfig, Source)>,
    run_extra_args: (&'p [String], Source),
    retries: (RetryPolicy, Source),
    flaky_result: (FlakyResult, Source),
    slow_timeout: (SlowTimeout, Source),
    leak_timeout: (LeakTimeout, Source),
    test_group: (TestGroup, Source),
    success_output: (TestOutputDisplay, Source),
    failure_output: (TestOutputDisplay, Source),
    junit_store_success_output: (bool, Source),
    junit_store_failure_output: (bool, Source),
    junit_report_skipped: (ReportSkipPolicy, Source),
    junit_flaky_fail_status: (JunitFlakyFailStatus, Source),
}

pub(crate) trait TrackSource<'p>: Sized {
    fn track_default<T>(value: T) -> (T, Self);
    fn track_profile<T>(value: T) -> (T, Self);
    fn track_override<T>(value: T, source: &'p CompiledOverride<FinalConfig>) -> (T, Self);
    fn track_script<T>(value: T, source: &'p CompiledProfileScripts<FinalConfig>) -> (T, Self);
}

impl<'p> TrackSource<'p> for () {
    fn track_default<T>(value: T) -> (T, Self) {
        (value, ())
    }

    fn track_profile<T>(value: T) -> (T, Self) {
        (value, ())
    }

    fn track_override<T>(value: T, _source: &'p CompiledOverride<FinalConfig>) -> (T, Self) {
        (value, ())
    }

    fn track_script<T>(value: T, _source: &'p CompiledProfileScripts<FinalConfig>) -> (T, Self) {
        (value, ())
    }
}

#[derive(Copy, Clone, Debug)]
pub(crate) enum SettingSource<'p> {
    /// A default configuration not specified in, or possible to override from,
    /// a profile.
    Default,

    /// A configuration specified in a profile.
    Profile,

    /// An override specified in a profile.
    Override(&'p CompiledOverride<FinalConfig>),

    /// An override specified in the `scripts` section.
    #[expect(dead_code)]
    Script(&'p CompiledProfileScripts<FinalConfig>),
}

impl<'p> TrackSource<'p> for SettingSource<'p> {
    fn track_default<T>(value: T) -> (T, Self) {
        (value, SettingSource::Default)
    }

    fn track_profile<T>(value: T) -> (T, Self) {
        (value, SettingSource::Profile)
    }

    fn track_override<T>(value: T, source: &'p CompiledOverride<FinalConfig>) -> (T, Self) {
        (value, SettingSource::Override(source))
    }

    fn track_script<T>(value: T, source: &'p CompiledProfileScripts<FinalConfig>) -> (T, Self) {
        (value, SettingSource::Script(source))
    }
}

impl<'p> TestSettings<'p> {
    /// Returns the test's priority.
    pub fn priority(&self) -> TestPriority {
        self.priority.0
    }

    /// Returns the number of threads required for this test.
    pub fn threads_required(&self) -> ThreadsRequired {
        self.threads_required.0
    }

    /// Returns the run-time wrapper script for this test.
    pub fn run_wrapper(&self) -> Option<&'p WrapperScriptConfig> {
        self.run_wrapper.map(|(script, _)| script)
    }

    /// Returns extra arguments to pass at runtime for this test.
    pub fn run_extra_args(&self) -> &'p [String] {
        self.run_extra_args.0
    }

    /// Returns the number of retries for this test.
    pub fn retries(&self) -> RetryPolicy {
        self.retries.0
    }

    /// Returns the flaky result behavior for this test.
    pub fn flaky_result(&self) -> FlakyResult {
        self.flaky_result.0
    }

    /// Returns the slow timeout for this test.
    pub fn slow_timeout(&self) -> SlowTimeout {
        self.slow_timeout.0
    }

    /// Returns the leak timeout for this test.
    pub fn leak_timeout(&self) -> LeakTimeout {
        self.leak_timeout.0
    }

    /// Returns the test group for this test.
    pub fn test_group(&self) -> &TestGroup {
        &self.test_group.0
    }

    /// Returns the success output setting for this test.
    pub fn success_output(&self) -> TestOutputDisplay {
        self.success_output.0
    }

    /// Returns the failure output setting for this test.
    pub fn failure_output(&self) -> TestOutputDisplay {
        self.failure_output.0
    }

    /// Returns whether success output should be stored in JUnit.
    pub fn junit_store_success_output(&self) -> bool {
        self.junit_store_success_output.0
    }

    /// Returns whether failure output should be stored in JUnit.
    pub fn junit_store_failure_output(&self) -> bool {
        self.junit_store_failure_output.0
    }

    /// Returns which skipped tests should be reported in JUnit.
    pub fn junit_report_skipped(&self) -> ReportSkipPolicy {
        self.junit_report_skipped.0
    }

    /// Returns the JUnit flaky-fail status for this test.
    pub fn junit_flaky_fail_status(&self) -> JunitFlakyFailStatus {
        self.junit_flaky_fail_status.0
    }
}

#[expect(dead_code)]
impl<'p, Source: Copy> TestSettings<'p, Source> {
    pub(in crate::config) fn new(
        profile: &'p EvaluatableProfile<'_>,
        run_mode: NextestRunMode,
        query: &TestQuery<'_>,
    ) -> Self
    where
        Source: TrackSource<'p>,
    {
        let ecx = profile.filterset_ecx();

        let mut priority = None;
        let mut threads_required = None;
        let mut run_wrapper = None;
        let mut run_extra_args = None;
        let mut retries = None;
        let mut flaky_result = None;
        let mut slow_timeout = None;
        let mut leak_timeout = None;
        let mut test_group = None;
        let mut success_output = None;
        let mut failure_output = None;
        let mut junit_store_success_output = None;
        let mut junit_store_failure_output = None;
        let mut junit_report_skipped = None;
        let mut junit_flaky_fail_status = None;

        for override_ in &profile.compiled_data.overrides {
            if !override_.matches_test_query(query, &ecx) {
                continue;
            }

            if priority.is_none()
                && let Some(p) = override_.data.priority
            {
                priority = Some(Source::track_override(p, override_));
            }
            if threads_required.is_none()
                && let Some(t) = override_.data.threads_required
            {
                threads_required = Some(Source::track_override(t, override_));
            }
            if run_extra_args.is_none()
                && let Some(r) = override_.data.run_extra_args.as_deref()
            {
                run_extra_args = Some(Source::track_override(r, override_));
            }
            if retries.is_none()
                && let Some(r) = override_.data.retries
            {
                retries = Some(Source::track_override(r, override_));
            }
            if flaky_result.is_none()
                && let Some(fr) = override_.data.flaky_result
            {
                flaky_result = Some(Source::track_override(fr, override_));
            }
            if slow_timeout.is_none() {
                // Use the appropriate slow timeout based on run mode. Note that
                // there's no fallback from bench to test timeout.
                let timeout_for_mode = match run_mode {
                    NextestRunMode::Test => override_.data.slow_timeout,
                    NextestRunMode::Benchmark => override_.data.bench_slow_timeout,
                };
                if let Some(s) = timeout_for_mode {
                    slow_timeout = Some(Source::track_override(s, override_));
                }
            }
            if leak_timeout.is_none()
                && let Some(l) = override_.data.leak_timeout
            {
                leak_timeout = Some(Source::track_override(l, override_));
            }
            if test_group.is_none()
                && let Some(t) = &override_.data.test_group
            {
                test_group = Some(Source::track_override(t.clone(), override_));
            }
            if success_output.is_none()
                && let Some(s) = override_.data.success_output
            {
                success_output = Some(Source::track_override(s, override_));
            }
            if failure_output.is_none()
                && let Some(f) = override_.data.failure_output
            {
                failure_output = Some(Source::track_override(f, override_));
            }
            if junit_store_success_output.is_none()
                && let Some(s) = override_.data.junit.store_success_output
            {
                junit_store_success_output = Some(Source::track_override(s, override_));
            }
            if junit_store_failure_output.is_none()
                && let Some(f) = override_.data.junit.store_failure_output
            {
                junit_store_failure_output = Some(Source::track_override(f, override_));
            }
            if junit_report_skipped.is_none()
                && let Some(s) = override_.data.junit.report_skipped
            {
                junit_report_skipped = Some(Source::track_override(s, override_));
            }
            if junit_flaky_fail_status.is_none()
                && let Some(s) = override_.data.junit.flaky_fail_status
            {
                junit_flaky_fail_status = Some(Source::track_override(s, override_));
            }
        }

        for override_ in &profile.compiled_data.scripts {
            if !override_.is_enabled(query, &ecx) {
                continue;
            }

            if run_wrapper.is_none()
                && let Some(wrapper) = &override_.run_wrapper
            {
                run_wrapper = Some(Source::track_script(wrapper.clone(), override_));
            }
        }

        // If no overrides were found, use the profile defaults.
        let priority = priority.unwrap_or_else(|| Source::track_default(TestPriority::default()));
        let threads_required =
            threads_required.unwrap_or_else(|| Source::track_profile(profile.threads_required()));
        let run_wrapper = run_wrapper.map(|wrapper| map_wrapper_script(profile, wrapper));
        let run_extra_args =
            run_extra_args.unwrap_or_else(|| Source::track_profile(profile.run_extra_args()));
        let retries = retries.unwrap_or_else(|| Source::track_profile(profile.retries()));
        let flaky_result =
            flaky_result.unwrap_or_else(|| Source::track_profile(profile.flaky_result()));
        let slow_timeout =
            slow_timeout.unwrap_or_else(|| Source::track_profile(profile.slow_timeout(run_mode)));
        let leak_timeout =
            leak_timeout.unwrap_or_else(|| Source::track_profile(profile.leak_timeout()));
        let test_group = test_group.unwrap_or_else(|| Source::track_profile(TestGroup::Global));
        let success_output =
            success_output.unwrap_or_else(|| Source::track_profile(profile.success_output()));
        let failure_output =
            failure_output.unwrap_or_else(|| Source::track_profile(profile.failure_output()));
        let junit_store_success_output = junit_store_success_output.unwrap_or_else(|| {
            // If the profile doesn't have JUnit enabled, success output can just be false.
            Source::track_profile(profile.junit().is_some_and(|j| j.store_success_output()))
        });
        let junit_store_failure_output = junit_store_failure_output.unwrap_or_else(|| {
            // If the profile doesn't have JUnit enabled, failure output can just be false.
            Source::track_profile(profile.junit().is_some_and(|j| j.store_failure_output()))
        });
        let junit_report_skipped = junit_report_skipped.unwrap_or_else(|| {
            Source::track_profile(
                profile
                    .junit()
                    .map_or(ReportSkipPolicy::default(), |j| j.report_skipped()),
            )
        });
        let junit_flaky_fail_status = junit_flaky_fail_status.unwrap_or_else(|| {
            Source::track_profile(
                profile
                    .junit()
                    .map_or(JunitFlakyFailStatus::default(), |j| j.flaky_fail_status()),
            )
        });

        TestSettings {
            threads_required,
            run_extra_args,
            run_wrapper,
            retries,
            flaky_result,
            priority,
            slow_timeout,
            leak_timeout,
            test_group,
            success_output,
            failure_output,
            junit_store_success_output,
            junit_store_failure_output,
            junit_report_skipped,
            junit_flaky_fail_status,
        }
    }

    /// Returns the number of threads required for this test, with the source attached.
    pub(crate) fn threads_required_with_source(&self) -> (ThreadsRequired, Source) {
        self.threads_required
    }

    /// Returns the number of retries for this test, with the source attached.
    pub(crate) fn retries_with_source(&self) -> (RetryPolicy, Source) {
        self.retries
    }

    /// Returns the slow timeout for this test, with the source attached.
    pub(crate) fn slow_timeout_with_source(&self) -> (SlowTimeout, Source) {
        self.slow_timeout
    }

    /// Returns the leak timeout for this test, with the source attached.
    pub(crate) fn leak_timeout_with_source(&self) -> (LeakTimeout, Source) {
        self.leak_timeout
    }

    /// Returns the test group for this test, with the source attached.
    pub(crate) fn test_group_with_source(&self) -> &(TestGroup, Source) {
        &self.test_group
    }
}

fn map_wrapper_script<'p, Source>(
    profile: &'p EvaluatableProfile<'_>,
    (script, source): (ScriptId, Source),
) -> (&'p WrapperScriptConfig, Source)
where
    Source: TrackSource<'p>,
{
    let wrapper_config = profile
        .script_config()
        .wrapper
        .get(&script)
        .unwrap_or_else(|| {
            panic!(
                "wrapper script {script} not found \
                 (should have been checked while reading config)"
            )
        });
    (wrapper_config, source)
}

#[derive(Clone, Debug)]
pub(in crate::config) struct CompiledByProfile {
    pub(in crate::config) default: CompiledData<PreBuildPlatform>,
    pub(in crate::config) other: HashMap<String, CompiledData<PreBuildPlatform>>,
}

impl CompiledByProfile {
    pub(in crate::config) fn new(
        pcx: &ParseContext<'_>,
        config: &NextestConfigImpl,
    ) -> Result<Self, ConfigParseErrorKind> {
        let mut errors = vec![];
        let default = CompiledData::new(
            pcx,
            "default",
            Some(config.default_profile().default_filter()),
            config.default_profile().overrides(),
            config.default_profile().setup_scripts(),
            &mut errors,
        );
        let other: HashMap<_, _> = config
            .other_profiles()
            .map(|(profile_name, profile)| {
                (
                    profile_name.to_owned(),
                    CompiledData::new(
                        pcx,
                        profile_name,
                        profile.default_filter(),
                        profile.overrides(),
                        profile.scripts(),
                        &mut errors,
                    ),
                )
            })
            .collect();

        if errors.is_empty() {
            Ok(Self { default, other })
        } else {
            Err(ConfigParseErrorKind::CompileErrors(errors))
        }
    }

    /// Returns the compiled data for the default config.
    ///
    /// The default config does not depend on the package graph, so we create it separately here.
    /// But we don't implement `Default` to make sure that the value is for the default _config_,
    /// not the default _profile_ (which repo config can customize).
    pub(in crate::config) fn for_default_config() -> Self {
        Self {
            default: CompiledData {
                profile_default_filter: Some(CompiledDefaultFilter::for_default_config()),
                overrides: vec![],
                scripts: vec![],
            },
            other: HashMap::new(),
        }
    }
}

/// A compiled form of the default filter for a profile.
///
/// Returned by [`EvaluatableProfile::default_filter`].
#[derive(Clone, Debug)]
pub struct CompiledDefaultFilter {
    /// The compiled expression.
    ///
    /// This is a bit tricky -- in some cases, the default config is constructed without a
    /// `PackageGraph` being available. But parsing filtersets requires a `PackageGraph`. So we hack
    /// around it by only storing the compiled expression here, and by setting it to `all()` (which
    /// matches the config).
    ///
    /// This does make the default-filter defined in default-config.toml a bit
    /// of a lie (since we don't use it directly, but instead replicate it in
    /// code). But it's not too bad.
    pub expr: CompiledExpr,

    /// The profile name the default filter originates from.
    pub profile: String,

    /// The section of the config that the default filter comes from.
    pub section: CompiledDefaultFilterSection,
}

impl CompiledDefaultFilter {
    pub(crate) fn for_default_config() -> Self {
        Self {
            expr: CompiledExpr::ALL,
            profile: NextestConfig::DEFAULT_PROFILE.to_owned(),
            section: CompiledDefaultFilterSection::Profile,
        }
    }

    /// Displays a configuration string for the default filter.
    pub fn display_config(&self, bold_style: Style) -> String {
        match &self.section {
            CompiledDefaultFilterSection::Profile => {
                format!("profile.{}.default-filter", self.profile)
                    .style(bold_style)
                    .to_string()
            }
            CompiledDefaultFilterSection::Override(_) => {
                format!(
                    "default-filter in {}",
                    format!("profile.{}.overrides", self.profile).style(bold_style)
                )
            }
        }
    }
}

/// Within [`CompiledDefaultFilter`], the part of the config that the default
/// filter comes from.
#[derive(Clone, Copy, Debug)]
pub enum CompiledDefaultFilterSection {
    /// The config comes from the top-level `profile.<profile-name>.default-filter`.
    Profile,

    /// The config comes from the override at the given index.
    Override(usize),
}

#[derive(Clone, Debug)]
pub(in crate::config) struct CompiledData<State> {
    // The default filter specified at the profile level.
    //
    // Overrides might also specify their own filters, and in that case the
    // overrides take priority.
    pub(in crate::config) profile_default_filter: Option<CompiledDefaultFilter>,
    pub(in crate::config) overrides: Vec<CompiledOverride<State>>,
    pub(in crate::config) scripts: Vec<CompiledProfileScripts<State>>,
}

impl CompiledData<PreBuildPlatform> {
    fn new(
        pcx: &ParseContext<'_>,
        profile_name: &str,
        profile_default_filter: Option<&str>,
        overrides: &[DeserializedOverride],
        scripts: &[DeserializedProfileScriptConfig],
        errors: &mut Vec<ConfigCompileError>,
    ) -> Self {
        let profile_default_filter =
            profile_default_filter.and_then(|filter| {
                match Filterset::parse(
                    filter.to_owned(),
                    pcx,
                    FiltersetKind::DefaultFilter,
                    &KnownGroups::Unavailable,
                ) {
                    Ok(expr) => Some(CompiledDefaultFilter {
                        expr: expr.compiled,
                        profile: profile_name.to_owned(),
                        section: CompiledDefaultFilterSection::Profile,
                    }),
                    Err(err) => {
                        errors.push(ConfigCompileError {
                            profile_name: profile_name.to_owned(),
                            section: ConfigCompileSection::DefaultFilter,
                            kind: ConfigCompileErrorKind::Parse {
                                host_parse_error: None,
                                target_parse_error: None,
                                filter_parse_errors: vec![err],
                            },
                        });
                        None
                    }
                }
            });

        let overrides = overrides
            .iter()
            .enumerate()
            .filter_map(|(index, source)| {
                CompiledOverride::new(pcx, profile_name, index, source, errors)
            })
            .collect();
        let scripts = scripts
            .iter()
            .enumerate()
            .filter_map(|(index, source)| {
                CompiledProfileScripts::new(pcx, profile_name, index, source, errors)
            })
            .collect();
        Self {
            profile_default_filter,
            overrides,
            scripts,
        }
    }

    pub(in crate::config) fn extend_reverse(&mut self, other: Self) {
        // For the default filter, other wins (it is last, and after reversing, it will be first).
        if other.profile_default_filter.is_some() {
            self.profile_default_filter = other.profile_default_filter;
        }
        self.overrides.extend(other.overrides.into_iter().rev());
        self.scripts.extend(other.scripts.into_iter().rev());
    }

    pub(in crate::config) fn reverse(&mut self) {
        self.overrides.reverse();
        self.scripts.reverse();
    }

    /// Chains this data with another set of data, treating `other` as lower-priority than `self`.
    pub(in crate::config) fn chain(self, other: Self) -> Self {
        let profile_default_filter = self.profile_default_filter.or(other.profile_default_filter);
        let mut overrides = self.overrides;
        let mut scripts = self.scripts;
        overrides.extend(other.overrides);
        scripts.extend(other.scripts);
        Self {
            profile_default_filter,
            overrides,
            scripts,
        }
    }

    pub(in crate::config) fn apply_build_platforms(
        self,
        build_platforms: &BuildPlatforms,
    ) -> CompiledData<FinalConfig> {
        let profile_default_filter = self.profile_default_filter;
        let overrides = self
            .overrides
            .into_iter()
            .map(|override_| override_.apply_build_platforms(build_platforms))
            .collect();
        let setup_scripts = self
            .scripts
            .into_iter()
            .map(|setup_script| setup_script.apply_build_platforms(build_platforms))
            .collect();
        CompiledData {
            profile_default_filter,
            overrides,
            scripts: setup_scripts,
        }
    }
}

#[derive(Clone, Debug)]
pub(crate) struct CompiledOverride<State> {
    id: OverrideId,
    state: State,
    pub(in crate::config) data: ProfileOverrideData,
}

impl<State> CompiledOverride<State> {
    pub(crate) fn id(&self) -> &OverrideId {
        &self.id
    }
}

#[derive(Clone, Debug, Eq, Hash, PartialEq)]
pub(crate) struct OverrideId {
    pub(crate) profile_name: SmolStr,
    index: usize,
}

#[derive(Clone, Debug)]
pub(in crate::config) struct ProfileOverrideData {
    host_spec: MaybeTargetSpec,
    target_spec: MaybeTargetSpec,
    filter: Option<FilterOrDefaultFilter>,
    priority: Option<TestPriority>,
    threads_required: Option<ThreadsRequired>,
    run_extra_args: Option<Vec<String>>,
    retries: Option<RetryPolicy>,
    flaky_result: Option<FlakyResult>,
    slow_timeout: Option<SlowTimeout>,
    bench_slow_timeout: Option<SlowTimeout>,
    leak_timeout: Option<LeakTimeout>,
    pub(in crate::config) test_group: Option<TestGroup>,
    success_output: Option<TestOutputDisplay>,
    failure_output: Option<TestOutputDisplay>,
    junit: DeserializedJunitOutput,
}

impl CompiledOverride<PreBuildPlatform> {
    fn new(
        pcx: &ParseContext<'_>,
        profile_name: &str,
        index: usize,
        source: &DeserializedOverride,
        errors: &mut Vec<ConfigCompileError>,
    ) -> Option<Self> {
        if source.platform.host.is_none()
            && source.platform.target.is_none()
            && source.filter.is_none()
        {
            errors.push(ConfigCompileError {
                profile_name: profile_name.to_owned(),
                section: ConfigCompileSection::Override(index),
                kind: ConfigCompileErrorKind::ConstraintsNotSpecified {
                    default_filter_specified: source.default_filter.is_some(),
                },
            });
            return None;
        }

        let host_spec = MaybeTargetSpec::new(source.platform.host.as_deref());
        let target_spec = MaybeTargetSpec::new(source.platform.target.as_deref());
        let filter = source.filter.as_ref().map_or(Ok(None), |filter| {
            Some(Filterset::parse(
                filter.clone(),
                pcx,
                FiltersetKind::OverrideFilter,
                &KnownGroups::Unavailable,
            ))
            .transpose()
        });
        let default_filter = source.default_filter.as_ref().map_or(Ok(None), |filter| {
            Some(Filterset::parse(
                filter.clone(),
                pcx,
                FiltersetKind::DefaultFilter,
                &KnownGroups::Unavailable,
            ))
            .transpose()
        });

        match (host_spec, target_spec, filter, default_filter) {
            (Ok(host_spec), Ok(target_spec), Ok(filter), Ok(default_filter)) => {
                // At most one of filter and default-filter can be specified.
                let filter = match (filter, default_filter) {
                    (Some(_), Some(_)) => {
                        errors.push(ConfigCompileError {
                            profile_name: profile_name.to_owned(),
                            section: ConfigCompileSection::Override(index),
                            kind: ConfigCompileErrorKind::FilterAndDefaultFilterSpecified,
                        });
                        return None;
                    }
                    (Some(filter), None) => Some(FilterOrDefaultFilter::Filter(filter)),
                    (None, Some(default_filter)) => {
                        let compiled = CompiledDefaultFilter {
                            expr: default_filter.compiled,
                            profile: profile_name.to_owned(),
                            section: CompiledDefaultFilterSection::Override(index),
                        };
                        Some(FilterOrDefaultFilter::DefaultFilter(compiled))
                    }
                    (None, None) => None,
                };

                Some(Self {
                    id: OverrideId {
                        profile_name: profile_name.into(),
                        index,
                    },
                    state: PreBuildPlatform {},
                    data: ProfileOverrideData {
                        host_spec,
                        target_spec,
                        filter,
                        priority: source.priority,
                        threads_required: source.threads_required,
                        run_extra_args: source.run_extra_args.clone(),
                        retries: source.retries,
                        flaky_result: source.flaky_result,
                        slow_timeout: source.slow_timeout,
                        bench_slow_timeout: source.bench.slow_timeout,
                        leak_timeout: source.leak_timeout,
                        test_group: source.test_group.clone(),
                        success_output: source.success_output,
                        failure_output: source.failure_output,
                        junit: source.junit,
                    },
                })
            }
            (maybe_host_err, maybe_target_err, maybe_filter_err, maybe_default_filter_err) => {
                let host_parse_error = maybe_host_err.err();
                let target_parse_error = maybe_target_err.err();
                let filter_parse_errors = maybe_filter_err
                    .err()
                    .into_iter()
                    .chain(maybe_default_filter_err.err())
                    .collect();

                errors.push(ConfigCompileError {
                    profile_name: profile_name.to_owned(),
                    section: ConfigCompileSection::Override(index),
                    kind: ConfigCompileErrorKind::Parse {
                        host_parse_error,
                        target_parse_error,
                        filter_parse_errors,
                    },
                });
                None
            }
        }
    }

    pub(in crate::config) fn apply_build_platforms(
        self,
        build_platforms: &BuildPlatforms,
    ) -> CompiledOverride<FinalConfig> {
        let host_eval = self.data.host_spec.eval(&build_platforms.host.platform);
        let host_test_eval = self.data.target_spec.eval(&build_platforms.host.platform);
        let target_eval = build_platforms
            .target
            .as_ref()
            .map_or(host_test_eval, |target| {
                self.data.target_spec.eval(&target.triple.platform)
            });

        CompiledOverride {
            id: self.id,
            state: FinalConfig {
                host_eval,
                host_test_eval,
                target_eval,
            },
            data: self.data,
        }
    }
}

impl CompiledOverride<FinalConfig> {
    /// Returns the target spec.
    pub(crate) fn target_spec(&self) -> &MaybeTargetSpec {
        &self.data.target_spec
    }

    /// Returns the filter to apply to overrides, if any.
    pub(crate) fn filter(&self) -> Option<&Filterset> {
        match self.data.filter.as_ref() {
            Some(FilterOrDefaultFilter::Filter(filter)) => Some(filter),
            _ => None,
        }
    }

    /// Returns true if this override's platform and filter constraints
    /// match the given test query.
    pub(in crate::config) fn matches_test_query(
        &self,
        query: &TestQuery<'_>,
        ecx: &nextest_filtering::EvalContext<'_>,
    ) -> bool {
        if !self.state.host_eval {
            return false;
        }
        if query.binary_query.platform == BuildPlatform::Host && !self.state.host_test_eval {
            return false;
        }
        if query.binary_query.platform == BuildPlatform::Target && !self.state.target_eval {
            return false;
        }
        // If no expression is present, it's equivalent to "all()".
        if let Some(expr) = self.filter()
            && !expr.matches_test(query, ecx)
        {
            return false;
        }
        true
    }

    /// Returns the default filter if it matches the platform.
    pub(crate) fn default_filter_if_matches_platform(&self) -> Option<&CompiledDefaultFilter> {
        match self.data.filter.as_ref() {
            Some(FilterOrDefaultFilter::DefaultFilter(filter)) => {
                // Which kind of evaluation to assume: matching the *target*
                // filter against the *target* platform (host_eval +
                // target_eval), or matching the *target* filter against the
                // *host* platform (host_eval + host_test_eval)? The former
                // makes much more sense, since in a cross-compile scenario you
                // want to match a (host, target) pair.
                (self.state.host_eval && self.state.target_eval).then_some(filter)
            }
            _ => None,
        }
    }
}

/// Represents a [`TargetSpec`] that might have been provided.
#[derive(Clone, Debug, Default)]
pub(crate) enum MaybeTargetSpec {
    Provided(TargetSpec),
    #[default]
    Any,
}

impl MaybeTargetSpec {
    pub(in crate::config) fn new(platform_str: Option<&str>) -> Result<Self, target_spec::Error> {
        Ok(match platform_str {
            Some(platform_str) => {
                MaybeTargetSpec::Provided(TargetSpec::new(platform_str.to_owned())?)
            }
            None => MaybeTargetSpec::Any,
        })
    }

    pub(in crate::config) fn eval(&self, platform: &Platform) -> bool {
        match self {
            MaybeTargetSpec::Provided(spec) => spec
                .eval(platform)
                .unwrap_or(/* unknown results are mapped to true */ true),
            MaybeTargetSpec::Any => true,
        }
    }
}

/// Either a filter override or a default filter specified for a platform.
///
/// At most one of these can be specified.
#[derive(Clone, Debug)]
pub(crate) enum FilterOrDefaultFilter {
    Filter(Filterset),
    DefaultFilter(CompiledDefaultFilter),
}

/// Deserialized form of profile overrides before compilation.
#[derive(Clone, Debug, Deserialize)]
#[cfg_attr(feature = "config-schema", derive(schemars::JsonSchema))]
#[cfg_attr(feature = "config-schema", schemars(deny_unknown_fields))]
#[serde(rename_all = "kebab-case")]
pub(in crate::config) struct DeserializedOverride {
    /// Host and/or target platforms this override applies to.
    #[serde(default)]
    platform: PlatformStrings,
    /// Filterset expression selecting tests this override applies to.
    #[serde(default)]
    filter: Option<String>,
    // Overrides start here.
    //
    // (This used to use serde(flatten) but that has issues:
    // https://github.com/serde-rs/serde/issues/2312.)
    // ---
    /// Priority for matching tests; higher values run sooner.
    #[serde(default)]
    priority: Option<TestPriority>,
    /// Replaces `default-filter` for matching platforms. Requires `platform`
    /// and must not be combined with `filter`.
    #[serde(default)]
    default_filter: Option<String>,
    /// Number of threads each matching test reserves from the pool.
    #[serde(default)]
    threads_required: Option<ThreadsRequired>,
    /// Extra arguments to pass to matching test binaries.
    #[serde(default)]
    run_extra_args: Option<Vec<String>>,
    /// Retry policy for matching tests.
    #[serde(
        default,
        deserialize_with = "crate::config::elements::deserialize_retry_policy"
    )]
    retries: Option<RetryPolicy>,
    /// Whether to treat matching flaky tests as passing or failing.
    #[serde(default)]
    flaky_result: Option<FlakyResult>,
    /// Slow timeout for matching tests.
    #[serde(
        default,
        deserialize_with = "crate::config::elements::deserialize_slow_timeout"
    )]
    slow_timeout: Option<SlowTimeout>,
    /// Leak timeout for matching tests.
    #[serde(
        default,
        deserialize_with = "crate::config::elements::deserialize_leak_timeout"
    )]
    leak_timeout: Option<LeakTimeout>,
    /// Test group to put matching tests in.
    #[serde(default)]
    test_group: Option<TestGroup>,
    /// When to display output for matching successful tests.
    #[serde(default)]
    success_output: Option<TestOutputDisplay>,
    /// When to display output for matching failed tests.
    #[serde(default)]
    failure_output: Option<TestOutputDisplay>,
    /// JUnit XML output settings for matching tests.
    #[serde(default)]
    junit: DeserializedJunitOutput,
    /// Benchmark-specific overrides for matching tests.
    #[serde(default)]
    bench: DeserializedOverrideBench,
}

#[derive(Copy, Clone, Debug, Default, Deserialize)]
#[cfg_attr(feature = "config-schema", derive(schemars::JsonSchema))]
#[cfg_attr(feature = "config-schema", schemars(deny_unknown_fields))]
#[serde(rename_all = "kebab-case")]
pub(in crate::config) struct DeserializedJunitOutput {
    /// Whether to store successful output for matching tests in the JUnit XML
    /// report.
    store_success_output: Option<bool>,
    /// Whether to store failed output for matching tests in the JUnit XML
    /// report.
    store_failure_output: Option<bool>,
    /// Which skipped tests to emit for matching tests in the JUnit XML report.
    report_skipped: Option<ReportSkipPolicy>,
    /// How flaky-fail tests are reported in the JUnit XML report.
    flaky_fail_status: Option<JunitFlakyFailStatus>,
}

/// Deserialized form of benchmark-specific overrides.
#[derive(Clone, Debug, Default, Deserialize)]
#[cfg_attr(feature = "config-schema", derive(schemars::JsonSchema))]
#[cfg_attr(feature = "config-schema", schemars(deny_unknown_fields))]
#[serde(rename_all = "kebab-case")]
pub(in crate::config) struct DeserializedOverrideBench {
    /// Slow timeout for matching benchmarks.
    #[serde(
        default,
        deserialize_with = "crate::config::elements::deserialize_slow_timeout"
    )]
    slow_timeout: Option<SlowTimeout>,
}

#[derive(Clone, Debug, Default)]
pub(in crate::config) struct PlatformStrings {
    pub(in crate::config) host: Option<String>,
    pub(in crate::config) target: Option<String>,
}

#[cfg(feature = "config-schema")]
impl schemars::JsonSchema for PlatformStrings {
    fn schema_name() -> std::borrow::Cow<'static, str> {
        "PlatformStrings".into()
    }

    fn json_schema(generator: &mut schemars::SchemaGenerator) -> schemars::Schema {
        schemars::json_schema!({
            "oneOf": [
                generator.subschema_for::<String>(),
                {
                    "type": "object",
                    "properties": {
                        "host": {
                            "type": ["string", "null"],
                        },
                        "target": {
                            "type": ["string", "null"],
                        },
                    },
                    "additionalProperties": false,
                }
            ]
        })
    }
}

impl<'de> Deserialize<'de> for PlatformStrings {
    fn deserialize<D: Deserializer<'de>>(deserializer: D) -> Result<Self, D::Error> {
        struct V;

        impl<'de2> serde::de::Visitor<'de2> for V {
            type Value = PlatformStrings;

            fn expecting(&self, formatter: &mut std::fmt::Formatter) -> std::fmt::Result {
                formatter.write_str(
                    "a table ({ host = \"x86_64-apple-darwin\", \
                        target = \"cfg(windows)\" }) \
                        or a string (\"x86_64-unknown-gnu-linux\")",
                )
            }

            fn visit_str<E>(self, v: &str) -> Result<Self::Value, E>
            where
                E: serde::de::Error,
            {
                Ok(PlatformStrings {
                    host: None,
                    target: Some(v.to_owned()),
                })
            }

            fn visit_map<A>(self, map: A) -> Result<Self::Value, A::Error>
            where
                A: serde::de::MapAccess<'de2>,
            {
                #[derive(Deserialize)]
                struct PlatformStringsInner {
                    #[serde(default)]
                    host: Option<String>,
                    #[serde(default)]
                    target: Option<String>,
                }

                let inner = PlatformStringsInner::deserialize(
                    serde::de::value::MapAccessDeserializer::new(map),
                )?;
                Ok(PlatformStrings {
                    host: inner.host,
                    target: inner.target,
                })
            }
        }

        deserializer.deserialize_any(V)
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::config::{
        core::NextestConfig,
        elements::{LeakTimeoutResult, SlowTimeoutResult},
        utils::test_helpers::*,
    };
    use camino_tempfile::tempdir;
    use indoc::indoc;
    use nextest_metadata::TestCaseName;
    use std::{num::NonZeroUsize, time::Duration};
    use test_case::test_case;

    /// Basic test to ensure overrides work. Add new override parameters to this test.
    #[test]
    fn test_overrides_basic() {
        let config_contents = indoc! {r#"
            # Override 1
            [[profile.default.overrides]]
            platform = 'aarch64-apple-darwin'  # this is the target platform
            filter = "test(test)"
            retries = { backoff = "exponential", count = 20, delay = "1s", max-delay = "20s" }
            slow-timeout = { period = "120s", terminate-after = 1, grace-period = "0s" }
            success-output = "immediate-final"
            junit = { store-success-output = true }

            # Override 2
            [[profile.default.overrides]]
            filter = "test(test)"
            threads-required = 8
            retries = 3
            slow-timeout = "60s"
            leak-timeout = "300ms"
            test-group = "my-group"
            failure-output = "final"
            junit = { store-failure-output = false, report-skipped = "none" }

            # Override 3
            [[profile.default.overrides]]
            platform = { host = "cfg(unix)" }
            filter = "test(override3)"
            retries = 5

            # Override 4 -- host not matched
            [[profile.default.overrides]]
            platform = { host = 'aarch64-apple-darwin' }
            retries = 10

            # Override 5 -- no filter provided, just platform
            [[profile.default.overrides]]
            platform = { host = 'cfg(target_os = "linux")', target = 'aarch64-apple-darwin' }
            filter = "test(override5)"
            retries = 8

            # Override 6 -- timeout result success
            [[profile.default.overrides]]
            filter = "test(timeout_success)"
            slow-timeout = { period = "30s", on-timeout = "pass" }

            [profile.default.junit]
            path = "my-path.xml"
            report-skipped = "all"

            [test-groups.my-group]
            max-threads = 20
        "#};

        let workspace_dir = tempdir().unwrap();

        let graph = temp_workspace(&workspace_dir, config_contents);
        let package_id = graph.workspace().iter().next().unwrap().id();

        let pcx = ParseContext::new(&graph);

        let nextest_config_result = NextestConfig::from_sources(
            graph.workspace().root(),
            &pcx,
            None,
            &[][..],
            &Default::default(),
        )
        .expect("config is valid");
        let profile = nextest_config_result
            .profile("default")
            .expect("valid profile name")
            .apply_build_platforms(&build_platforms());

        // This query matches override 2.
        let host_binary_query =
            binary_query(&graph, package_id, "lib", "my-binary", BuildPlatform::Host);
        let test_name = TestCaseName::new("test");
        let query = TestQuery {
            binary_query: host_binary_query.to_query(),
            test_name: &test_name,
        };
        let overrides = profile.settings_for(NextestRunMode::Test, &query);

        assert_eq!(overrides.threads_required(), ThreadsRequired::Count(8));
        assert_eq!(overrides.retries(), RetryPolicy::new_without_delay(3));
        assert_eq!(
            overrides.slow_timeout(),
            SlowTimeout {
                period: Duration::from_secs(60),
                on_timeout: SlowTimeoutResult::default(),
                terminate_after: None,
                grace_period: Duration::from_secs(10),
            }
        );
        assert_eq!(
            overrides.leak_timeout(),
            LeakTimeout {
                period: Duration::from_millis(300),
                result: LeakTimeoutResult::Pass,
            }
        );
        assert_eq!(overrides.test_group(), &test_group("my-group"));
        assert_eq!(overrides.success_output(), TestOutputDisplay::Never);
        assert_eq!(overrides.failure_output(), TestOutputDisplay::Final);
        // For clarity.
        #[expect(clippy::bool_assert_comparison)]
        {
            assert_eq!(overrides.junit_store_success_output(), false);
            assert_eq!(overrides.junit_store_failure_output(), false);
        }
        assert_eq!(overrides.junit_report_skipped(), ReportSkipPolicy::None);

        // This query matches override 1 and 2.
        let target_binary_query = binary_query(
            &graph,
            package_id,
            "lib",
            "my-binary",
            BuildPlatform::Target,
        );
        let test_name = TestCaseName::new("test");
        let query = TestQuery {
            binary_query: target_binary_query.to_query(),
            test_name: &test_name,
        };
        let overrides = profile.settings_for(NextestRunMode::Test, &query);

        assert_eq!(overrides.threads_required(), ThreadsRequired::Count(8));
        assert_eq!(
            overrides.retries(),
            RetryPolicy::Exponential {
                count: 20,
                delay: Duration::from_secs(1),
                jitter: false,
                max_delay: Some(Duration::from_secs(20)),
            }
        );
        assert_eq!(
            overrides.slow_timeout(),
            SlowTimeout {
                period: Duration::from_secs(120),
                terminate_after: Some(NonZeroUsize::new(1).unwrap()),
                grace_period: Duration::ZERO,
                on_timeout: SlowTimeoutResult::default(),
            }
        );
        assert_eq!(
            overrides.leak_timeout(),
            LeakTimeout {
                period: Duration::from_millis(300),
                result: LeakTimeoutResult::Pass,
            }
        );
        assert_eq!(overrides.test_group(), &test_group("my-group"));
        assert_eq!(
            overrides.success_output(),
            TestOutputDisplay::ImmediateFinal
        );
        assert_eq!(overrides.failure_output(), TestOutputDisplay::Final);
        // For clarity.
        #[expect(clippy::bool_assert_comparison)]
        {
            assert_eq!(overrides.junit_store_success_output(), true);
            assert_eq!(overrides.junit_store_failure_output(), false);
        }

        // This query matches override 3.
        let test_name = TestCaseName::new("override3");
        let query = TestQuery {
            binary_query: target_binary_query.to_query(),
            test_name: &test_name,
        };
        let overrides = profile.settings_for(NextestRunMode::Test, &query);
        assert_eq!(overrides.retries(), RetryPolicy::new_without_delay(5));

        // This query matches override 5.
        let test_name = TestCaseName::new("override5");
        let query = TestQuery {
            binary_query: target_binary_query.to_query(),
            test_name: &test_name,
        };
        let overrides = profile.settings_for(NextestRunMode::Test, &query);
        assert_eq!(overrides.retries(), RetryPolicy::new_without_delay(8));

        // This query matches override 6.
        let test_name = TestCaseName::new("timeout_success");
        let query = TestQuery {
            binary_query: target_binary_query.to_query(),
            test_name: &test_name,
        };
        let overrides = profile.settings_for(NextestRunMode::Test, &query);
        assert_eq!(
            overrides.slow_timeout(),
            SlowTimeout {
                period: Duration::from_secs(30),
                on_timeout: SlowTimeoutResult::Pass,
                terminate_after: None,
                grace_period: Duration::from_secs(10),
            }
        );

        // This query does not match any overrides.
        let test_name = TestCaseName::new("no_match");
        let query = TestQuery {
            binary_query: target_binary_query.to_query(),
            test_name: &test_name,
        };
        let overrides = profile.settings_for(NextestRunMode::Test, &query);
        assert_eq!(overrides.retries(), RetryPolicy::new_without_delay(0));
        assert_eq!(overrides.junit_report_skipped(), ReportSkipPolicy::All);
    }

    /// Test that bench.slow-timeout works correctly in overrides.
    #[test]
    fn test_overrides_bench_slow_timeout() {
        let config_contents = indoc! {r#"
            # Profile-level benchmark slow-timeout (used as fallback).
            [profile.default]
            bench.slow-timeout = { period = "30y" }

            # Override 1: Both test and bench slow-timeout specified.
            [[profile.default.overrides]]
            filter = "test(both_specified)"
            slow-timeout = "60s"
            bench.slow-timeout = { period = "5m", terminate-after = 2 }

            # Override 2: Only test slow-timeout specified.
            [[profile.default.overrides]]
            filter = "test(test_only)"
            slow-timeout = "90s"

            # Override 3: Only bench slow-timeout specified.
            [[profile.default.overrides]]
            filter = "test(bench_only)"
            bench.slow-timeout = "10m"
        "#};

        let workspace_dir = tempdir().unwrap();
        let graph = temp_workspace(&workspace_dir, config_contents);
        let package_id = graph.workspace().iter().next().unwrap().id();
        let pcx = ParseContext::new(&graph);

        let nextest_config_result = NextestConfig::from_sources(
            graph.workspace().root(),
            &pcx,
            None,
            &[][..],
            &Default::default(),
        )
        .expect("config is valid");
        let profile = nextest_config_result
            .profile("default")
            .expect("valid profile name")
            .apply_build_platforms(&build_platforms());

        let host_binary_query =
            binary_query(&graph, package_id, "lib", "my-binary", BuildPlatform::Host);

        // Test "both_specified": tests get slow-timeout, benchmarks get
        // bench.slow-timeout.
        let test_name = TestCaseName::new("both_specified");
        let query = TestQuery {
            binary_query: host_binary_query.to_query(),
            test_name: &test_name,
        };

        let test_settings = profile.settings_for(NextestRunMode::Test, &query);
        assert_eq!(test_settings.slow_timeout().period, Duration::from_secs(60));

        let bench_settings = profile.settings_for(NextestRunMode::Benchmark, &query);
        assert_eq!(
            bench_settings.slow_timeout(),
            SlowTimeout {
                period: Duration::from_secs(5 * 60),
                terminate_after: Some(NonZeroUsize::new(2).unwrap()),
                grace_period: Duration::from_secs(10),
                on_timeout: SlowTimeoutResult::default(),
            }
        );

        // Test "test_only": tests get the override, benchmarks fall back to
        // profile default (no fallback from slow-timeout to
        // bench.slow-timeout).
        let test_name = TestCaseName::new("test_only");
        let query = TestQuery {
            binary_query: host_binary_query.to_query(),
            test_name: &test_name,
        };

        let test_settings = profile.settings_for(NextestRunMode::Test, &query);
        assert_eq!(test_settings.slow_timeout().period, Duration::from_secs(90));

        let bench_settings = profile.settings_for(NextestRunMode::Benchmark, &query);
        // Should use profile-level bench.slow-timeout (30 years), not the
        // override's slow-timeout. humantime parses "30y" accounting for leap
        // years, so we check >= VERY_LARGE rather than an exact value.
        assert!(
            bench_settings.slow_timeout().period >= SlowTimeout::VERY_LARGE.period,
            "should be >= VERY_LARGE, got {:?}",
            bench_settings.slow_timeout().period
        );

        // Test "bench_only": tests get profile default, benchmarks get the
        // override.
        let test_name = TestCaseName::new("bench_only");
        let query = TestQuery {
            binary_query: host_binary_query.to_query(),
            test_name: &test_name,
        };

        let test_settings = profile.settings_for(NextestRunMode::Test, &query);
        // Tests use the default slow-timeout (60s from default-config.toml).
        assert_eq!(test_settings.slow_timeout().period, Duration::from_secs(60));

        let bench_settings = profile.settings_for(NextestRunMode::Benchmark, &query);
        assert_eq!(
            bench_settings.slow_timeout().period,
            Duration::from_secs(10 * 60)
        );
    }

    #[test_case(
        indoc! {r#"
            [[profile.default.overrides]]
            retries = 2
        "#},
        "default",
        &[MietteJsonReport {
            message: "at least one of `platform` and `filter` must be specified".to_owned(),
            labels: vec![],
        }]

        ; "neither platform nor filter specified"
    )]
    #[test_case(
        indoc! {r#"
            [[profile.default.overrides]]
            default-filter = "test(test1)"
            retries = 2
        "#},
        "default",
        &[MietteJsonReport {
            message: "for override with `default-filter`, `platform` must also be specified".to_owned(),
            labels: vec![],
        }]

        ; "default-filter without platform"
    )]
    #[test_case(
        indoc! {r#"
            [[profile.default.overrides]]
            platform = 'cfg(unix)'
            default-filter = "not default()"
            retries = 2
        "#},
        "default",
        &[MietteJsonReport {
            message: "predicate not allowed in `default-filter` expressions".to_owned(),
            labels: vec![
                MietteJsonLabel {
                    label: "default() causes infinite recursion".to_owned(),
                    span: MietteJsonSpan { offset: 4, length: 9 },
                },
            ],
        }]

        ; "default filterset in default-filter"
    )]
    #[test_case(
        indoc! {r#"
            [[profile.default.overrides]]
            filter = 'test(test1)'
            default-filter = "test(test2)"
            retries = 2
        "#},
        "default",
        &[MietteJsonReport {
            message: "at most one of `filter` and `default-filter` must be specified".to_owned(),
            labels: vec![],
        }]

        ; "both filter and default-filter specified"
    )]
    #[test_case(
        indoc! {r#"
            [[profile.default.overrides]]
            filter = 'test(test1)'
            platform = 'cfg(unix)'
            default-filter = "test(test2)"
            retries = 2
        "#},
        "default",
        &[MietteJsonReport {
            message: "at most one of `filter` and `default-filter` must be specified".to_owned(),
            labels: vec![],
        }]

        ; "both filter and default-filter specified with platform"
    )]
    #[test_case(
        indoc! {r#"
            [[profile.default.overrides]]
            platform = {}
            retries = 2
        "#},
        "default",
        &[MietteJsonReport {
            message: "at least one of `platform` and `filter` must be specified".to_owned(),
            labels: vec![],
        }]

        ; "empty platform map"
    )]
    #[test_case(
        indoc! {r#"
            [[profile.ci.overrides]]
            platform = 'cfg(target_os = "macos)'
            retries = 2
        "#},
        "ci",
        &[MietteJsonReport {
            message: "error parsing cfg() expression".to_owned(),
            labels: vec![
                MietteJsonLabel { label: "unclosed quotes".to_owned(), span: MietteJsonSpan { offset: 16, length: 6 } }
            ]
        }]

        ; "invalid platform expression"
    )]
    #[test_case(
        indoc! {r#"
            [[profile.ci.overrides]]
            filter = 'test(/foo)'
            retries = 2
        "#},
        "ci",
        &[MietteJsonReport {
            message: "expected close regex".to_owned(),
            labels: vec![
                MietteJsonLabel { label: "missing `/`".to_owned(), span: MietteJsonSpan { offset: 9, length: 0 } }
            ]
        }]

        ; "invalid filterset"
    )]
    #[test_case(
        // Not strictly an override error, but convenient to put here.
        indoc! {r#"
            [profile.ci]
            default-filter = "test(foo) or default()"
        "#},
        "ci",
        &[MietteJsonReport {
            message: "predicate not allowed in `default-filter` expressions".to_owned(),
            labels: vec![
                MietteJsonLabel { label: "default() causes infinite recursion".to_owned(), span: MietteJsonSpan { offset: 13, length: 9 } }
            ]
        }]

        ; "default-filter with default"
    )]
    fn parse_overrides_invalid(
        config_contents: &str,
        faulty_profile: &str,
        expected_reports: &[MietteJsonReport],
    ) {
        let workspace_dir = tempdir().unwrap();

        let graph = temp_workspace(&workspace_dir, config_contents);
        let pcx = ParseContext::new(&graph);

        let err = NextestConfig::from_sources(
            graph.workspace().root(),
            &pcx,
            None,
            [],
            &Default::default(),
        )
        .expect_err("config is invalid");
        match err.kind() {
            ConfigParseErrorKind::CompileErrors(compile_errors) => {
                assert_eq!(
                    compile_errors.len(),
                    1,
                    "exactly one override error must be produced"
                );
                let error = compile_errors.first().unwrap();
                assert_eq!(
                    error.profile_name, faulty_profile,
                    "compile error profile matches"
                );
                let handler = miette::JSONReportHandler::new();
                let reports = error
                    .kind
                    .reports()
                    .map(|report| {
                        let mut out = String::new();
                        handler.render_report(&mut out, report.as_ref()).unwrap();

                        let json_report: MietteJsonReport = serde_json::from_str(&out)
                            .unwrap_or_else(|err| {
                                panic!(
                                    "failed to deserialize JSON message produced by miette: {err}"
                                )
                            });
                        json_report
                    })
                    .collect::<Vec<_>>();
                assert_eq!(&reports, expected_reports, "reports match");
            }
            other => {
                panic!(
                    "for config error {other:?}, expected ConfigParseErrorKind::FiltersetOrCfgParseError"
                );
            }
        };
    }

    /// Test that `cfg(unix)` works with a custom platform.
    ///
    /// This was broken with older versions of target-spec.
    #[test]
    fn cfg_unix_with_custom_platform() {
        let config_contents = indoc! {r#"
            [[profile.default.overrides]]
            platform = { host = "cfg(unix)" }
            filter = "test(test)"
            retries = 5
        "#};

        let workspace_dir = tempdir().unwrap();

        let graph = temp_workspace(&workspace_dir, config_contents);
        let package_id = graph.workspace().iter().next().unwrap().id();
        let pcx = ParseContext::new(&graph);

        let nextest_config = NextestConfig::from_sources(
            graph.workspace().root(),
            &pcx,
            None,
            &[][..],
            &Default::default(),
        )
        .expect("config is valid");

        let build_platforms = custom_build_platforms(workspace_dir.path());

        let profile = nextest_config
            .profile("default")
            .expect("valid profile name")
            .apply_build_platforms(&build_platforms);

        // Check that the override is correctly applied.
        let target_binary_query = binary_query(
            &graph,
            package_id,
            "lib",
            "my-binary",
            BuildPlatform::Target,
        );
        let test_name = TestCaseName::new("test");
        let query = TestQuery {
            binary_query: target_binary_query.to_query(),
            test_name: &test_name,
        };
        let overrides = profile.settings_for(NextestRunMode::Test, &query);
        assert_eq!(
            overrides.retries(),
            RetryPolicy::new_without_delay(5),
            "retries applied to custom platform"
        );
    }
}